Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: exclude third level dependencies #481

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

deathemperor
Copy link

@deathemperor deathemperor commented Aug 8, 2023

addresses #312

@deathemperor
Copy link
Author

@floydspace can you have a look at this please? I still have to use patching for this with my deployment

@floydspace
Copy link
Owner

Hey @deathemperor
Last time I checked, the tests were failing, and it is still the case, could you please fix tests
here is the error from Ci Expected '!==' and instead saw '!='

@deathemperor
Copy link
Author

@floydspace I've updated the code, can you run the tests again please? thanks.

@deathemperor
Copy link
Author

deathemperor commented Mar 8, 2024

still wish to have this done, any idea what preventing it from getting merged @floydspace ?

@danrivett
Copy link

Curious about this PR and whether it would help us reduce the zip size when comparing the zip generated by serverless-webpack vs serverless-esbuild.

I can't see which tests are failing, but I assume that is the main thing preventing this PR from moving forward to code review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants